-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support request.query decoding #126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add some doc and ready to be merged
@guicassolato so this works for your use-case(s)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👾
0b63a97
to
c9ae52a
Compare
@eguzki is this ok? Or are you still expecting more changes? |
Signed-off-by: Alex Snaps <[email protected]>
Signed-off-by: Alex Snaps <[email protected]>
Signed-off-by: Alex Snaps <[email protected]>
Signed-off-by: Alex Snaps <[email protected]>
Signed-off-by: Alex Snaps <[email protected]>
c9ae52a
to
cdc899d
Compare
So reading this:
Wondering if we shouldn't always have the first param in our fmt.Sprintf("decodeQueryString(request.query)['%s'] == '%s'", queryParam.Name, queryParam.Value) @guicassolato do you have an opinion? |
Alternate proposal, that I'll implement here right now, pass an optional 2nd bool param, that would dictate whether to return a See this PR on the Kuadrant Operator side |
Signed-off-by: Alex Snaps <[email protected]>
b44823c
to
a8632ce
Compare
Signed-off-by: Alex Snaps <[email protected]>
…only Signed-off-by: Alex Snaps <[email protected]>
In description it says |
See test, but this effectively works like this, given the query string
param1=%F0%9F%91%BE%20¶m2=Exterminate%21&%F0%9F%91%BE=123&%F0%9F%91%BE=456
i.e.:
It is exposed as an "extension" that's only enabled via
Expression::new_extended
, but mostly thruPredicate::route_rule
that's now only used in the config, when compilingRouteRuleConditions